View Issue Details

IDProjectCategoryView StatusLast Update
0000168file[All Projects] Generalpublic2020-06-18 16:25
ReportergyakovlevAssigned Tochristos 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in VersionHEAD 
Summary0000168: file-5.39[seccomp][ppc64]: error: invalid application of 'sizeof' to incomplete type 'struct termios'
Descriptiondownstream bug: https://bugs.gentoo.org/728416

file-5.39/src/seccomp.c: In function 'enable_sandbox_full':
file-5.39/work/file-5.39/src/seccomp.c:194:19: error: invalid application of 'sizeof' to incomplete type 'struct termios'
  194 | ALLOW_IOCTL_RULE(TCGETS);
      | ^~~~~~
file-5.39/work/file-5.39/src/seccomp.c:194:2: note: in expansion of macro 'ALLOW_IOCTL_RULE'
  194 | ALLOW_IOCTL_RULE(TCGETS);
      | ^~~~~~~~~~~~~~~~
make[3]: *** [Makefile:558: seccomp.o] Error 1
make[3]: *** Waiting for unfinished jobs...


Additional InformationOn PPC64, TCGETS is defined in terms of struct termios, so it must include termios.h

adding
#ifdef __powerpc64__
#include <termios.h>
#endif

to src/seccomp.c fixes the build.
TagsNo tags attached.

Activities

gyakovlev

2020-06-15 20:53

reporter   ~0003429

someone pointed out it may be not ppc64 specific and
it should probably just include <termios.h> unconditionally.

christos

2020-06-18 16:25

manager   ~0003430

Fixed, thanks!

Issue History

Date Modified Username Field Change
2020-06-15 20:36 gyakovlev New Issue
2020-06-15 20:53 gyakovlev Note Added: 0003429
2020-06-18 16:25 christos Assigned To => christos
2020-06-18 16:25 christos Status new => assigned
2020-06-18 16:25 christos Status assigned => resolved
2020-06-18 16:25 christos Resolution open => fixed
2020-06-18 16:25 christos Fixed in Version => HEAD
2020-06-18 16:25 christos Note Added: 0003430