View Issue Details

IDProjectCategoryView StatusLast Update
0000017fileGeneralpublic2018-08-01 09:02
Reportercbiedl Assigned Tochristos  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
PlatformLinuxOSDebianOS Versionall
Summary0000017: NULL check for ms in magic_setparam, magic_getparam?

all the public functions in magic.c that take a "struct magic_set" as parameter check at first whether it's NULL. However, magic_setparam and magic_getparam do not. By intention?

Next step was to ask whether the "val" void pointer shouldn't be checked before dereferencing it. And all the other pointers that are provided in various functions.

TagsNo tags attached.



2018-07-25 06:27

manager   ~0000015

Thanks, for now I've added the ms == NULL tests for consistency.


2018-08-01 09:02

manager   ~0000022

feedback timeout

Issue History

Date Modified Username Field Change
2018-07-24 22:45 cbiedl New Issue
2018-07-25 06:27 christos Assigned To => christos
2018-07-25 06:27 christos Status new => assigned
2018-07-25 06:27 christos Status assigned => feedback
2018-07-25 06:27 christos Note Added: 0000015
2018-08-01 09:02 christos Status feedback => resolved
2018-08-01 09:02 christos Resolution open => fixed
2018-08-01 09:02 christos Note Added: 0000022