View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000291 | file | General | public | 2021-09-24 14:09 | 2021-11-16 19:35 |
| Reporter | rootkea | Assigned To | christos | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | assigned | Resolution | open | ||
| Summary | 0000291: scan-build reports multiple logic errors | ||||
| Description | Hello! On latest master, scan-build[0] reports multiple logical errors. Please see the scan-build report here: https://rootkea.gitlab.io/file/scan-build/ Here's the .gitlab-ci.yml which generated this scan-build report: https://gitlab.com/rootkea/file/-/raw/gitlab-scan-build/.gitlab-ci.yml Thanks! [0] https://clang-analyzer.llvm.org/scan-build | ||||
| Tags | No tags attached. | ||||
|
|
Fixed all but the vfork() ones. Yes, lseek(2)/close(2) are not strictly legal to call after vfork(2), but if you follow the strict rules, then the number of cases you can use vfork(2) become close to 0. |
|
|
Can we replace `vfork()` with safer `posix_spawn()` as suggested by scan-build? |
|
|
We can, and perhaps we should. It is a bit of work though... We'd also want to keep the old vfork code (or change it to use fork) for systems that don't have posix_spawn |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-09-24 14:09 | rootkea | New Issue | |
| 2021-10-28 16:24 | christos | Assigned To | => christos |
| 2021-10-28 16:24 | christos | Status | new => assigned |
| 2021-10-28 16:37 | christos | Status | assigned => feedback |
| 2021-10-28 16:37 | christos | Note Added: 0003664 | |
| 2021-10-29 05:11 | rootkea | Note Added: 0003667 | |
| 2021-10-29 05:11 | rootkea | Status | feedback => assigned |
| 2021-11-16 19:35 | christos | Note Added: 0003677 |
