|
|
image.png (3,142 bytes) |
|
|
Thinking about it... "PR/351: CathyKMeow: octalify unprintable characters in filenames unless raw" why are characters ≥ U+0080 even considererd unprintable? The change was originally introduced because of some issues with control characters < U+0020 (especially \n), see Bug 351. |
|
|
Bug 351 is closed and i can't comment there, so commen here. 1) `ls` and `find` replace non-printable characters only if stdout is a tty. There are no character replacement for piped output: ``` $ mkdir a$'\n'b $ ls | cat a b $ find . | cat . ./a b ``` 2) Characters above 0x80 aren't non-printable. |
|
|
Hm, the changes from bug 351 lead to Midnight commander not properly detecting images with umlauts etc. in the file name. See https://www.midnight-commander.org/ticket/4377 I find it strange that midnight commander would not use piped output, so in theory the change should not even have any effect. without the -r option, all characters above 0x80 get octalified. alex@horus:~> file testö.jpg test\303\266.jp: JPEG image data, JFIF standard 1.01, resolution (DPCM), density 118x118, segment length 16, progressive, precision 8, 1706x1132, components 3 |
|
|
> I find it strange that midnight commander would not use piped output, so in theory the change should not even have any effect. Yep, two overlapped issues together lead to the bug. First, `file` utility corrupts filenames. Second, `mc` relays on filename from file's output. First one can be fixed by checking isatty(STDOUT_FILENO) as other tools do. Second one can be fixed by removing filename from output with --brief option (or even using libmagic directly). But i can't understand why after all non-ascii characters are considered as non-printable. |
|
|
Sorry ro-ee, maybe i misunderstood your previous comment. I know about mc bug and commented there also. I was going to create a ticket for `file` here but you made it first. Fix for "bug 351" is implemented incorrectly. I'd take CathyKMeow's attention but can't comment or reopen ticket 351. This issue affects not only mc but any other software which invokes `file` and reads filename, also it confuses users. |
|
|
Try it now. |
- Anonymous
