View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000041 | file | General | public | 2018-09-16 07:00 | 2018-10-01 18:49 |
| Reporter | petk | Assigned To | christos | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 5.34 | ||||
| Fixed in Version | 5.35 | ||||
| Summary | 0000041: Obsolete HAVE_LIMITS_H symbol | ||||
| Description | The <limits.h> header file is part of the standard C89 headers [1] and on current systems there is no need to manually check if header is present anymore. Since the code requires at least C89 or greater, the HAVE_LIMITS_H symbol defined by Autoconf in configure.ac [2] can be removed and simplifed. Refs: [1] https://port70.net/~nsz/c/c89/c89-draft.html#4.1.2 [2] https://git.savannah.gnu.org/cgit/autoconf.git/tree/lib/autoconf/headers.m4 | ||||
| Additional Information | Pull request for additional info and overview of this is at https://github.com/file/file/pull/39 | ||||
| Tags | No tags attached. | ||||
|
|
39.patch (3,246 bytes)
From e2b2d1cc12803f1b477a532f5280cfd7fd15340c Mon Sep 17 00:00:00 2001
From: Peter Kokot <peterkokot@gmail.com>
Date: Sun, 16 Sep 2018 03:56:00 +0200
Subject: [PATCH] Remove HAVE_LIMITS_H
The `<limits.h>` header file is part of the standard C89 headers [1] and
on current systems there is no need to manually check if header is
present anymore.
Since the code requires at least C89 or greater, the `HAVE_LIMITS_H`
symbol defined by Autoconf in configure.ac [2] can be removed and
simplifed.
Refs:
[1] https://port70.net/~nsz/c/c89/c89-draft.html#4.1.2
[2] https://git.savannah.gnu.org/cgit/autoconf.git/tree/lib/autoconf/headers.m4
---
configure.ac | 2 +-
src/apprentice.c | 2 --
src/cdf.c | 2 --
src/funcs.c | 2 --
src/magic.c | 2 --
src/vasprintf.c | 2 --
6 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/configure.ac b/configure.ac
index ab4f6fc21..43da77afb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -91,7 +91,7 @@ AC_HEADER_STDC
AC_HEADER_MAJOR
AC_HEADER_SYS_WAIT
AC_CHECK_HEADERS(stdint.h fcntl.h locale.h stdint.h inttypes.h unistd.h)
-AC_CHECK_HEADERS(stddef.h utime.h wchar.h wctype.h limits.h)
+AC_CHECK_HEADERS(stddef.h utime.h wchar.h wctype.h)
AC_CHECK_HEADERS(getopt.h err.h xlocale.h signal.h)
AC_CHECK_HEADERS(sys/mman.h sys/stat.h sys/types.h sys/utime.h sys/time.h)
if test "$enable_zlib" != "no"; then
diff --git a/src/apprentice.c b/src/apprentice.c
index 28a513f66..fbc789247 100644
--- a/src/apprentice.c
+++ b/src/apprentice.c
@@ -51,9 +51,7 @@ FILE_RCSID("@(#)$File: apprentice.c,v 1.279 2018/09/09 20:33:28 christos Exp $")
#include <sys/mman.h>
#endif
#include <dirent.h>
-#if defined(HAVE_LIMITS_H)
#include <limits.h>
-#endif
#define EATAB {while (isascii((unsigned char) *l) && \
diff --git a/src/cdf.c b/src/cdf.c
index b4a9c488e..7b3774c3e 100644
--- a/src/cdf.c
+++ b/src/cdf.c
@@ -47,9 +47,7 @@ FILE_RCSID("@(#)$File: cdf.c,v 1.111 2018/09/09 20:33:28 christos Exp $")
#include <string.h>
#include <time.h>
#include <ctype.h>
-#ifdef HAVE_LIMITS_H
#include <limits.h>
-#endif
#ifndef EFTYPE
#define EFTYPE EINVAL
diff --git a/src/funcs.c b/src/funcs.c
index 8193bdffa..d2326b45f 100644
--- a/src/funcs.c
+++ b/src/funcs.c
@@ -42,9 +42,7 @@ FILE_RCSID("@(#)$File: funcs.c,v 1.99 2018/08/20 10:08:18 christos Exp $")
#if defined(HAVE_WCTYPE_H)
#include <wctype.h>
#endif
-#if defined(HAVE_LIMITS_H)
#include <limits.h>
-#endif
#ifndef SIZE_MAX
#define SIZE_MAX ((size_t)~0)
diff --git a/src/magic.c b/src/magic.c
index b774f1bd1..600cf83b9 100644
--- a/src/magic.c
+++ b/src/magic.c
@@ -44,9 +44,7 @@ FILE_RCSID("@(#)$File: magic.c,v 1.105 2018/08/02 12:53:51 christos Exp $")
#ifdef QUICK
#include <sys/mman.h>
#endif
-#ifdef HAVE_LIMITS_H
#include <limits.h> /* for PIPE_BUF */
-#endif
#if defined(HAVE_UTIMES)
# include <sys/time.h>
diff --git a/src/vasprintf.c b/src/vasprintf.c
index 8d0531541..a04253be1 100644
--- a/src/vasprintf.c
+++ b/src/vasprintf.c
@@ -116,9 +116,7 @@ FILE_RCSID("@(#)$File: vasprintf.c,v 1.15 2018/09/09 20:33:28 christos Exp $")
#include <stdlib.h>
#include <stdarg.h>
#include <ctype.h>
-#ifdef HAVE_LIMITS_H
#include <limits.h>
-#endif
#ifdef HAVE_STDDEF_H
#include <stddef.h>
#endif
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-09-16 07:00 | petk | New Issue | |
| 2018-09-16 07:00 | petk | File Added: 39.patch | |
| 2018-10-01 18:48 | christos | Assigned To | => christos |
| 2018-10-01 18:48 | christos | Status | new => assigned |
| 2018-10-01 18:49 | christos | Status | assigned => resolved |
| 2018-10-01 18:49 | christos | Resolution | open => fixed |
| 2018-10-01 18:49 | christos | Fixed in Version | => 5.35 |