View Issue Details

IDProjectCategoryView StatusLast Update
0000027file[All Projects] Generalpublic2018-08-11 11:32
ReportercbiedlAssigned Tochristos 
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version5.35 
Summary0000027: Fix HPROF detection
DescriptionSeems it wasn't my brightest day when I submitted "Java HPROF dumps" a few years ago. So: "short" should have been "byte", this breaks detection on big endian. And the creation stamp should be printed only if the previous line matched. Patch below.

Besides, the URL is 404.
TagsNo tags attached.
Attach Tags

Activities

cbiedl

2018-08-06 19:37

reporter  

hprof.patch (657 bytes)
commit 87535393d786980b7f5c27890bfe91213884d3d6
Author: Christoph Biedl <debian.axhn@manchmal.in-ulm.de>
Date:   Mon Aug 6 00:07:00 2018 +0200

    Fix HPROF detection on big endian

diff --git a/magic/Magdir/java b/magic/Magdir/java
index da72ce9c..91f85506 100644
--- a/magic/Magdir/java
+++ b/magic/Magdir/java
@@ -22,6 +22,6 @@
 # Java HPROF dumps
 # https://java.net/downloads/heap-snapshot/hprof-binary-format.html
 0	string		JAVA\x20PROFILE\x201.0.
->0x12	short		0
->>0x11	ushort-0x31	<2      Java HPROF dump,
->>0x17	beqdate/1000	x       created %s
+>0x12	byte		0
+>>0x11	ubyte-0x31	<2      Java HPROF dump,
+>>>0x17	beqdate/1000	x       created %s
hprof.patch (657 bytes)

christos

2018-08-11 11:32

manager   ~0000047

Applied, thanks!

Issue History

Date Modified Username Field Change
2018-08-06 19:37 cbiedl New Issue
2018-08-06 19:37 cbiedl File Added: hprof.patch
2018-08-11 11:32 christos Assigned To => christos
2018-08-11 11:32 christos Status new => assigned
2018-08-11 11:32 christos Status assigned => resolved
2018-08-11 11:32 christos Resolution open => fixed
2018-08-11 11:32 christos Fixed in Version => 5.35
2018-08-11 11:32 christos Note Added: 0000047