View Issue Details

IDProjectCategoryView StatusLast Update
0000291file[All Projects] Generalpublic2021-11-16 19:35
ReporterrootkeaAssigned Tochristos 
PrioritynormalSeverityminorReproducibilityhave not tried
Status assignedResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary0000291: scan-build reports multiple logic errors
DescriptionHello!

On latest master, scan-build[0] reports multiple logical errors. Please see the scan-build report here: https://rootkea.gitlab.io/file/scan-build/

Here's the .gitlab-ci.yml which generated this scan-build report: https://gitlab.com/rootkea/file/-/raw/gitlab-scan-build/.gitlab-ci.yml

Thanks!

[0] https://clang-analyzer.llvm.org/scan-build
TagsNo tags attached.

Activities

christos

2021-10-28 16:37

manager   ~0003664

Fixed all but the vfork() ones. Yes, lseek(2)/close(2) are not strictly legal to call after vfork(2), but if you follow the strict rules, then the number of cases you can use vfork(2) become close to 0.

rootkea

2021-10-29 05:11

reporter   ~0003667

Can we replace `vfork()` with safer `posix_spawn()` as suggested by scan-build?

christos

2021-11-16 19:35

manager   ~0003677

We can, and perhaps we should. It is a bit of work though... We'd also want to keep the old vfork code (or change it to use fork) for systems that don't have posix_spawn

Issue History

Date Modified Username Field Change
2021-09-24 14:09 rootkea New Issue
2021-10-28 16:24 christos Assigned To => christos
2021-10-28 16:24 christos Status new => assigned
2021-10-28 16:37 christos Status assigned => feedback
2021-10-28 16:37 christos Note Added: 0003664
2021-10-29 05:11 rootkea Note Added: 0003667
2021-10-29 05:11 rootkea Status feedback => assigned
2021-11-16 19:35 christos Note Added: 0003677