View Issue Details

IDProjectCategoryView StatusLast Update
0000559fileGeneralpublic2024-09-08 20:24
Reporterjsummers Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Product Version5.45 
Summary0000559: pcxLib pattern doesn't work
DescriptionThe "pcxLib" pattern doesn't identify any pcxLib files (using pattern files from 2024-09-04).
Steps To ReproduceUsing sample files from https://sembiance.com/fileFormatSamples/archive/pcxLib/

$ file CGA.MGL VC0256.VL WB0.WBL
CGA.MGL: data
VC0256.VL: data
WB0.WBL: data

Expected result:

CGA.MGL: pcxLib archive
VC0256.VL: pcxLib archive
WB0.WBL: pcxLib archive
Additional InformationThis is the relevant pattern:

0 string/b pcxLib
>0x0A string/b Copyright\020(c)\020Genus\020Microprogramming,\020Inc. pcxLib compressed

The immediate problem is that the test should be using hex 20, not octal 20.

Side note: There's another pattern, "ApriDisk", that has the same error.

But I don't think the pcxLib copyright string should be tested at all. My suggestion:

0 string/b pcxLib\0
>122 ubyte 0x01 pcxLib archive
>>144 uleshort 0 \b, uncompressed
>>144 uleshort !0 \b, compressed

(The last two lines are optional.)

Not that it matters, but I don't think the magic/Magdir/compress pattern file is the best place for pcxLib. It's some sort of graphics-oriented or game-oriented archive format that seems to be rarely if ever compressed.
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2024-09-08 20:24 jsummers New Issue